[libvirt] [PATCH] Use SED variable for `sed` binary in src/Makefile

Mitchell Hashimoto mitchell.hashimoto at gmail.com
Thu Sep 9 06:41:52 UTC 2010


Hm, the patch attached as binary data. Here is the attached patch as text.
Apologies about that:

---
 src/Makefile.am |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index b321657..118c329 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1029,14 +1029,14 @@ libvirt.syms: libvirt_public.syms $(USED_SYM_FILES)
 libvirt.def: libvirt.syms
        $(AM_V_GEN)rm -f -- $@-tmp $@ ; \
        printf 'EXPORTS\n' > $@-tmp && \
-       sed -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
\t]*\(.*\)\;/    \1/g' $^ >> $@-tmp && \
+       $(SED) -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
\t]*\(.*\)\;/    \1/g' $^ >> $@-tmp && \
        chmod a-w $@-tmp && \
        mv $@-tmp libvirt.def

 libvirt_qemu.def: $(srcdir)/libvirt_qemu.syms
        $(AM_V_GEN)rm -f -- $@-tmp $@ ; \
        printf 'EXPORTS\n' > $@-tmp && \
-       sed -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
\t]*\(.*\)\;/    \1/g' $^ >> $@-tmp && \
+       $(SED) -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
\t]*\(.*\)\;/    \1/g' $^ >> $@-tmp && \
        chmod a-w $@-tmp && \
        mv $@-tmp libvirt_qemu.def

-- 
1.7.2.2

On Wed, Sep 8, 2010 at 11:39 PM, Mitchell Hashimoto <
mitchell.hashimoto at gmail.com> wrote:

> Hi,
>
> I've been trying to get libvirt (client) to cleanly/easily compile on
> BSD-based systems (in this case OS X). "./configure" runs fine but the
> "make" caused an error with `sed` since BSD sed was reporting some sort of
> regex error. I realized that the "SED" variable was populated with "gsed"
> which worked properly. This made the make continue (failed again later, will
> address that when I can).
>
> This is my first contribution to a C-based project and I don't have much
> experience with autotools other than using them as a consumer. Let me know
> if anything can be improved.
>
> Thank you,
> Mitchell
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100908/24f08a85/attachment-0003.htm>


More information about the libvir-list mailing list