[libvirt] [PATCH 0/3] test cases for spoofing prevention

[Gerhard Stenzel]

On Fri, 2010-09-10 at 16:02 +0200, Gerhard Stenzel wrote:
> Sounds good and I will give it a try ...

All my tests worked except scripts/nwfilter/210-no-mac-spoofing.t, which
failed with on Fedora 13:
...
# ' > /test.sh
input must be 8 bytes long at /usr/lib64/perl5/Crypt/DES.pm line 57.
# Looks like you planned 4 tests but ran 3.
...

Here is the patch, that fixes the problem for me:

diff --git a/scripts/nwfilter/210-no-mac-spoofing.t
b/scripts/nwfilter/210-no-mac-spoofing.t
index df47fd7..2906e1f 100644
--- a/scripts/nwfilter/210-no-mac-spoofing.t
+++ b/scripts/nwfilter/210-no-mac-spoofing.t
@@ -25,6 +25,7 @@ The test case validates that MAC spoofing is prevented
 
 use strict;
 use warnings;
+use utf8;
 
 use Test::More tests => 4;
 
@@ -94,6 +95,7 @@ my $cmdfile = "echo '" .
     "/sbin/ifconfig eth0 up\n".
     "/sbin/ifconfig eth0\n".
     "' > /test.sh";
+utf8::encode ($cmdfile); 
 diag $cmdfile;
 my ($stdout, $stderr, $exit)  = $ssh->cmd($cmdfile);
 diag $stdout;


-- 
Best regards, 

Gerhard Stenzel, 
-----------------------------------------------------------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294