[libvirt] [PATCH] virsh: Use virBuffer for generating XML
Jiri Denemark
jdenemar at redhat.com
Tue Sep 14 15:11:39 UTC 2010
> > @@ -7903,52 +7904,40 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd)
> > }
> >
> > /* Make XML of interface */
> > - tmp = vshMalloc(ctl, 1);
> > - buf = vshMalloc(ctl, strlen(type) + 25);
> > - sprintf(buf, "<interface type='%s'>\n" , type);
> > + virBufferVSprintf(&buf, "<interface type='%s'>\n" , type);
>
> Weird spacing before the second comma
Oops, I didn't notice this weirdness in the original code and let it slip into
the new one. I fixed that and pushed, thanks.
Jirka
More information about the libvir-list
mailing list