[libvirt] [PATCH] libvirtd: improve the error message displayed on tls client auth failure

Eric Blake eblake at redhat.com
Wed Sep 15 16:24:29 UTC 2010


On 09/15/2010 10:11 AM, Justin Clift wrote:
> On 09/16/2010 02:03 AM, Daniel P. Berrange wrote:
>> On Thu, Sep 16, 2010 at 01:54:26AM +1000, Justin Clift wrote:
>>> This address BZ # 556599:
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=556599
>>> ---
>>> daemon/libvirtd.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> I co-incidentally fixed this in my DTrace patches too
>>
>> https://www.redhat.com/archives/libvir-list/2010-September/msg00239.html
>>
>> as well as removing all the function names from other log/error messages
>> since we capture that info automagically
>
> Oops... just noticed yours has a typo.
>
> "-infile" should be "--infile"
>
> Unlike "-i", it needs the two hyphens (according to the man page).

Meanwhile, danpb's DTrace patches are RFC status, while your patch 
addresses a BZ, so I say go ahead and apply yours.  I'm sure danpb can 
rebase accordingly. :)

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list