[libvirt] [PATCH 03/12] Adds xml entries for memory tunables
Nikunj A. Dadhania
nikunj at linux.vnet.ibm.com
Wed Sep 22 04:31:11 UTC 2010
On Tue, 21 Sep 2010 18:14:51 +0100, "Daniel P. Berrange" <berrange at redhat.com> wrote:
> On Mon, Sep 20, 2010 at 02:15:37PM +0530, Nikunj A. Dadhania wrote:
> > The patch adds xml entries to the domain.rng file.
> >
> > + <!-- Minimum amount of memory required to start the VM -->
> > + <optional>
> > + <element name="min_gaurantee">
>
> Small typo there, s/gaur/guar/
Sure
> > + <ref name="memoryKB"/>
> > + </element>
> > + </optional>
> > + <!-- Maximum swap area the VM can use -->
> > + <optional>
> > + <element name="swap_hard_limit">
> > + <ref name="memoryKB"/>
> > + </element>
> > + </optional>
> > + </element>
> > + </optional>
> > +
> > <optional>
>
> Also the indentation looks a bit wacky. Tabs in the file perhaps ?
>
I am not sure why! I had used emacs and the indentation was automatic.
> > <element name="vcpu">
> > <optional>
>
> The schema additions look fine to me though.
Cool.
Nikunj
More information about the libvir-list
mailing list