[libvirt] [PATCH V2] Rework configure logic for virtualport support

[Justin Clift]

On 09/29/2010 10:44 PM, Justin Clift wrote:
> On 09/29/2010 09:58 PM, Stefan Berger wrote:
> <snip>
>>> ACK.
>>>
>> Pushed.
>
> Ouch, that appears to have j
>
> Ouch, this just broke the ./configure script on Mac OS X:
>
> *****************
>
> checking for iconv... yes
> checking how to link with libiconv... -liconv
> checking for GNU gettext in libintl... yes
> checking whether to use NLS... yes
> checking where the gettext function comes from... external libintl
> checking how to link with libintl... -lintl
> checking for HAL... no
> checking for UDEV... no
> checking whether to compile with macvtap support... no
> configure: error: --with-virtualport requires --with-macvtap
> $
>
> *****************

Turns out this isn't an OS X problem.  :(

Just tested on a "known good" Linux box (Fedora 13), and this triggers
it:

   ./configure --without-macvtap

...

   checking for UDEV... yes
   checking for PCIACCESS... yes
   checking whether to compile with macvtap support... no
   configure: error: --with-virtualport requires --with-macvtap
   $

Looks like a logic flaw in the patch fragment here:

   if test "$with_virtualport" != "no"; then
       if test "$with_macvtap" = "no"; then
           AC_MSG_ERROR([--with-virtualport requires --with-macvtap])
       fi

With the default value of "check" for $with_virtualport, anything that
causes $with_macvtap to equal "no" causes this abort.

Created a patch to fix the problem and also let the "check" approach
still work.  It'll be the message following this (in this thread). :)

Regards and best wishes,

Justin Clift