[libvirt] [PATCH] configure: tweak logic flow of virtport check

Stefan Berger stefanb at linux.vnet.ibm.com
Wed Sep 29 15:39:05 UTC 2010


  On 09/29/2010 10:22 AM, Justin Clift wrote:
> This fixes a small logic bug, where passing --without-macvtap
> on the configure line, or otherwise indicating a lack of
> support for macvtap, causes configure to bail.
> ---
>   configure.ac |   13 ++++++++++++-
>   1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 8dcd756..f9b0d0f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2083,10 +2083,21 @@ AC_ARG_WITH([virtualport],
>     [with_virtualport=${withval}],
>     [with_virtualport=check])
>
> -if test "$with_virtualport" != "no"; then
> +dnl Warn the user and error out if they requested virtualport support with configure
> +dnl options, but the required macvtap support isn't available
> +
> +if test "$with_virtualport" = "yes"; then
>       if test "$with_macvtap" = "no"; then
>           AC_MSG_ERROR([--with-virtualport requires --with-macvtap])
>       fi
> +fi
> +
> +dnl virtualport checks
> +
> +if test "$with_macvtap" != "yes"; then
> +    with_virtualport=no
> +fi
> +if test "$with_virtualport" != "no"; then
>       AC_MSG_CHECKING([whether to compile with virtual port support])
>       AC_TRY_COMPILE([ #include<sys/socket.h>
>                        #include<linux/rtnetlink.h>  ],
Thanks. I saw the configure failure you posted, started working on a 
patch and then got busy doing something else...

Stefan




More information about the libvir-list mailing list