[libvirt] [Patch v3 0/5] nwfilter: Support comment attribute in filter rule descriptions

[Stefan Berger]

  On 09/30/2010 03:40 PM, Eric Blake wrote:
> On 09/30/2010 09:16 AM, Stefan Berger wrote:
>> V3:
>>   - moved MAX_COMMENT_LENGTH #define into include file (1/5)
>>   - renamed IPTABLES_MAX_COMMENT_SIZE to IPTABLES_MAX_COMMENT_LENGTH 
>> (2/5)
>>   - removal of regex from string patter in schema for comment 
>> attribute (3/5)
>>   - added libvirt version since when comment attribute is available 
>> (4/5)
>>   - added test cases (5/5)
>>
>> V2:
>>   - work on the iptables instantiation patch (2/5)
>>   - work on the parser patch (1/5)
>>   - small changes to the test cases (5/5)
>>
>> The following patch series adds support for a comment node to the XML
>> attributes of all protocols. If possible, as for example in case of 
>> iptables,
>> the comments are instantiated (iptables ... -m comment --comment ...).
>>
>> The patches do the following:
>> - extend the parser and XML generator to parse and create XML with the
>>    comment attribute
>> - instantiate the comment in case of ip(6)tables
>> - extend the nwfilter.rng schema with the comment attribute
>> - add the information to the web docs
>> - add a test case for the XML parser/generator to be run during 'make 
>> check'
>
> ACK series - all of these look good to me now!
>
Pushed.

   Stefan