[libvirt] [PATCH] virt-aa-helper: translate error messages

Eric Blake eblake at redhat.com
Thu Sep 30 21:19:03 UTC 2010


On 09/30/2010 03:13 PM, Eric Blake wrote:
> These messages are visible to the user, so they should be
> consistently translated.
>
> * cfg.mk (msg_gen_function): Add vah_error, vah_warning.
> * src/security/virt-aa-helper.c: Translate messages.
> (catchXMLError): Fix capitalization.
> ---
>
> I noticed this sitting on one of my branches (since May!) thanks
> to Jamie's recent apparmor patches.  Any objections?

Self-NACK - for translations to work, the locale has to be initialized 
at startup.  Hmm - coreutils has a syntax-check that validates whether 
all the main() functions initialized the locale; I wonder why it's not 
being used in libvirt?

At any rate, v2 of this patch coming up soon once I play with the idea 
of getting syntax-check to catch locale initialization.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list