[libvirt] [PATCH 1/3] Don't use virSetCloseExec in event loop on Win32

Eric Blake eblake at redhat.com
Tue Apr 5 15:31:17 UTC 2011


On 04/05/2011 09:03 AM, Daniel P. Berrange wrote:
> The virSetCloseExec API returns -1 on Win32 since it cannot
> possibly work. Avoid calling it from the event loop since
> is not required in this case.

Well, it _could_ work if gnulib would relax a couple modules to LGPLv2+
instead of their current LGPLv3+.

Meanwhile, mingw _does_ let us create a pipe already non-inheritible
(that is, pipe2(fds, O_CLOEXEC) _does_ work on mingw as an LGPLv2+
gnulib solution).

If you don't mind, I'd rather conditionally NAK this patch and try the
pipe2 approach instead, since the added in-function #ifdefs detract from
readability.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110405/25538992/attachment-0001.sig>


More information about the libvir-list mailing list