[libvirt] [PATCH] qemu: Do not unlink managedsave image if restoring fails.

[Daniel Berteaud]

Le mercredi 06 avril 2011 à 16:50 +0800, Daniel Veillard a écrit :
> > 
> > That is, I think:
> > 
> > virsh save dom file
> > virsh restore file
> > 
> > should leave file intact if and only if the restore failed, and:
> 
>   The problem there is that you are changing the command behaviour.
> The user may snapshot the disk separately and use this to implement
> a simplified domain snapshot. Doing the remove may avoid troubles
> for those not knowing what they are doing, but also break something
> for those who know what they are doing.

I completely agree, virsh restore shouldn't remove the saved state. I
often use this and restore several time the same dump, because I
independently save (and restore) the VM disk. I use this as domain
snapshots function because of the current limitations of the snapshot
API (only working for qcow2 image, and I only use LVM for performance
reason, I'm pretty sure a lot of user also use LVM, and would like to
keep the possibility to restore a saved state multiple time).

Regards, Daniel

>   In general I would tend to not change the established operation
> behaviour, especially on suddenly removing files owned by the user
> without asking. For managed save that's completely different due to the
> fact the file is owned by libvir, and removing is fine.
> 
> Daniel
> 

-- 
Daniel Berteaud
FIREWALL-SERVICES SARL.
Société de Services en Logiciels Libres
Technopôle Montesquieu
33650 MARTILLAC
Tel : 05 56 64 15 32
Fax : 05 56 64 15 32
Mail: daniel at firewall-services.com
Web : http://www.firewall-services.com