[libvirt] [PATCH] Write error check conditionals in more compact form for dispatcher
Eric Blake
eblake at redhat.com
Wed Apr 13 23:34:44 UTC 2011
On 04/13/2011 12:14 PM, Daniel P. Berrange wrote:
> Replace cases of
>
> type = virConnectGetType(conn);
> if (type == NULL)
> goto cleanup;
>
> With
>
> if (!(type = virConnectGetType(conn)))
> goto cleanup;
>
> * daemon/remote.c: Write error checks in compat form
> ---
> daemon/remote.c | 795 +++++++++++++++++++------------------------------------
> 1 files changed, 278 insertions(+), 517 deletions(-)
Not quite a 1:2 ration in + to -, but still fairly mechanical.
Didn't spot anything obviously wrong. I did see at least one variable
rename (from err to int) snuck in; but that's okay.
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110413/10aac5f3/attachment-0001.sig>
More information about the libvir-list
mailing list