[libvirt] [PATCH] esx: Extend VI generator to cover managed object types
Matthias Bolte
matthias.bolte at googlemail.com
Thu Apr 14 15:34:03 UTC 2011
2011/4/13 Daniel Veillard <veillard at redhat.com>:
> On Sun, Apr 10, 2011 at 01:27:56PM +0200, Matthias Bolte wrote:
>> Generate lookup functions for managed object types.
>> ---
>> src/esx/esx_vi.c | 414 +++++++++++++++++++++++-----------------
>> src/esx/esx_vi.h | 2 +
>> src/esx/esx_vi_generator.input | 28 +++-
>> src/esx/esx_vi_generator.py | 411 ++++++++++++++++++++++++++++++++++++++--
>> src/esx/esx_vi_types.c | 349 ++++++----------------------------
>> src/esx/esx_vi_types.h | 102 ++---------
>> 6 files changed, 728 insertions(+), 578 deletions(-)
>
> Hum, it's a fairly big patch, and I won't pretend to fully understand it.
> A cursory look didn't raised any issue to me, and since you're the one
> managing that code, the best is for you to push it and others to make
> sure everything still works well, so the earlier the better :-)
The actual resulting functional change in the driver is pretty small,
but moving it to the generator was a bit more complex. It took me a
moment to understand the details of my own code again to get the
macros right. Overall I'm quite sure that I didn't break something in
here, as its still working in my tests :)
>
> ACK,
>
> Daniel
>
Thanks, pushed.
Matthias
More information about the libvir-list
mailing list