[libvirt] [PATCH v2] Remove virConnectPtr from virRaiseErrorFull
Matthias Bolte
matthias.bolte at googlemail.com
Sun Apr 17 05:50:22 UTC 2011
2011/4/16 Eric Blake <eblake at redhat.com>:
> On 04/16/2011 02:32 AM, Matthias Bolte wrote:
>> And from all related macros and functions.
>> ---
>>
>> I posted v1 a year ago :)
>>
>> https://www.redhat.com/archives/libvir-list/2010-April/msg00164.html
>
> And I even ack'd it, but a lot has changed in the meantime.
>
>> +++ b/src/conf/cpu_conf.c
>> @@ -32,7 +32,7 @@
>> #define VIR_FROM_THIS VIR_FROM_CPU
>>
>> #define virCPUReportError(code, ...) \
>> - virReportErrorHelper(NULL, VIR_FROM_CPU, code, __FILE__, \
>> + virReportErrorHelper(VIR_FROM_CPU, code, __FILE__, \
>> __FUNCTION__, __LINE__, __VA_ARGS__)
>
> The argument was truly unused, so this is a nice cleanup.
>
> ACK.
>
Thanks, pushed now. I can't remember why I didn't push v1 :)
Matthias
More information about the libvir-list
mailing list