[libvirt] [PATCH] qemu: fix the check of virDomainObjUnref()'s return value

Wen Congyang wencongyang at gmail.com
Tue Apr 19 13:49:05 UTC 2011


于 2011-4-19 17:34, Daniel P. Berrange 写道:
> On Tue, Apr 19, 2011 at 10:08:21AM +0800, Wen Congyang wrote:
>> If vm is unlocked in virDomainObjUnref(), the return value is 0, not less
>> than 0.
>>
>> ---
>>   src/qemu/qemu_process.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>> index 1dfd005..7691cbe 100644
>> --- a/src/qemu/qemu_process.c
>> +++ b/src/qemu/qemu_process.c
>> @@ -433,7 +433,7 @@ qemuProcessHandleWatchdog(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
>>                */
>>               virDomainObjRef(vm);
>>               if (virThreadPoolSendJob(driver->workerPool, wdEvent)<  0) {
>> -                if (virDomainObjUnref(vm)<  0)
>> +                if (virDomainObjUnref(vm) == 0)
>>                       vm = NULL;
>>                   VIR_FREE(wdEvent);
>
> ACK

Thanks, pushed.

>
>
> Daniel




More information about the libvir-list mailing list