[libvirt] [PATCH] build: fix 32-bit test failure

Laine Stump laine at laine.org
Mon Apr 25 07:18:09 UTC 2011


On 04/21/2011 10:26 AM, Eric Blake wrote:
> ARRAY_CARDINALITY is typed as size_t, not long; this matters on 32-bit
> platforms:
>
> hashtest.c: In function 'testHashRemoveForEach':
> hashtest.c:114: error: format '%lu' expects type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat]
>
> * tests/hashtest.c (testHashRemoveForEach): Use correct format.
> ---
>
> Pushing under the build-breaker rule.
>
>   tests/hashtest.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/hashtest.c b/tests/hashtest.c
> index dff0181..722b44c 100644
> --- a/tests/hashtest.c
> +++ b/tests/hashtest.c
> @@ -112,7 +112,7 @@ testHashRemoveForEach(const void *data)
>       if (count != ARRAY_CARDINALITY(uuids)) {
>           if (virTestGetVerbose()) {
>               testError("\nvirHashForEach didn't go through all entries,"
> -                      " %d != %lu\n",
> +                      " %d != %zu\n",
>                         count, ARRAY_CARDINALITY(uuids));
>           }
>           goto cleanup;

ACK




More information about the libvir-list mailing list