[libvirt] [PATCH] tests: More unit tests for internal hash APIs
Jiri Denemark
jdenemar at redhat.com
Wed Apr 27 13:39:13 UTC 2011
On Tue, Apr 26, 2011 at 10:11:27 -0600, Eric Blake wrote:
> On 04/19/2011 07:22 AM, Jiri Denemark wrote:
> > This adds several tests for remaining hash APIs (custom
> > hasher/comparator functions are not covered yet, though).
> >
> > All tests pass both before and after the "Simplify hash implementation".
> > ---
> > src/util/hash.c | 18 +++
> > src/util/hash.h | 1 +
> > tests/hashdata.h | 237 +++++++++++++++++++++++++++++++++++-
> > tests/hashtest.c | 361 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 615 insertions(+), 2 deletions(-)
>
> Overall, this looks like a good patch; the fact that it passes 'make
> check' speaks highly, and it is some good additional coverage.
>
> ACK with nits fixed.
Thanks, I fixed the nits (inc. seeding the pseudo-random number generator) and
pushed.
Jirka
More information about the libvir-list
mailing list