[libvirt] [PATCH v2] util: Simplify hash implementation
Jiri Denemark
jdenemar at redhat.com
Wed Apr 27 13:39:40 UTC 2011
On Tue, Apr 12, 2011 at 13:10:15 -0600, Eric Blake wrote:
> On 04/12/2011 11:25 AM, Jiri Denemark wrote:
> > So far first entries for each hash key are stored directly in the hash
> > table while other entries mapped to the same key are linked through
> > pointers. As a result of that, the code is cluttered with special
> > handling for the first items.
> >
> > This patch makes all entries (even the first ones) linked through
> > pointers, which significantly simplifies the code and makes it more
> > maintainable.
> > ---
> > src/util/hash.c | 294 +++++++++++++++++--------------------------------------
> > 1 files changed, 92 insertions(+), 202 deletions(-)
>
> ACK - all the changes look correct, and certainly simpler.
Thanks, I pushed the patch since we have the unit test now.
Jirka
More information about the libvir-list
mailing list