[libvirt] [PATCH] Xen: Do not generate net ifname if domain is inactive

[Jim Fehlig]

Eric Blake wrote:
> On 04/28/2011 11:53 AM, Jim Fehlig wrote:
>   
>> The xend driver will generate a virDomainNetDef ifname if one is not
>> specified in xend sexpr, even if domain is inactive.  The result is
>> network interface XML containing 'vif-1.Y' on dev attribute of target
>> element, e.g.
>>
>>   <interface type='bridge'>
>>     <target dev='vif-1.0'/>
>>     ...
>>
>> This patch changes the behavior to only generate the ifname if not
>> specified in xend sexpr *and* domain is not inactive (id != -1).
>>     
>
> Makes sense for the rationale.  However...
>
>   
>> +            } else if (def->id != -1) {
>>                  snprintf(buf, sizeof(buf), "vif%d.%d", def->id, vif_index);
>> -                tmp = buf;
>> +                if (!(net->ifname = strdup(buf)))
>>     
>
> Rather than using snprintf and strdup, can't we just use:
>
> if (virAsprintf(&net->ifname, "vif%d.%d", def->id, vif_index) < 0)
>     goto no_memory;
>   

Yes, good point.  Here is a V2.

Regards,
Jim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xend-ifname.patch
Type: text/x-patch
Size: 2274 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110428/c45c5a07/attachment-0001.bin>