[libvirt] [libvirt-php] Remove strip from installation
Eric Blake
eblake at redhat.com
Fri Apr 1 14:51:07 UTC 2011
On 03/31/2011 11:25 PM, Lyre wrote:
> Make it able to generate debuginfo package.
>
> install-exec-local:
> - $(INSTALL) -m 644 -D --strip $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so
> + $(INSTALL) -m 644 -D $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so
> $(INSTALL) -m 755 -d $(DESTDIR)$(PHPCDIR)
> $(ECHO) "extension=$(PACKAGE).so" > $(DESTDIR)$(PHPCDIR)/libvirt-php.ini
Good change. GNU Coding Standards recommend, and Automake provides,
'make install' with debug vs. 'make install-strip' with stripped
binaries; and 'make install-strip' works by reinvoking 'make install'
with $(INSTALL) redefined to also do stripping. So it is still possible
to install things stripped by specifically asking for it, but stripping
should never be the default.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110401/6763e954/attachment-0001.sig>
More information about the libvir-list
mailing list