[libvirt] [PATCH] qemu: Do not unlink managedsave image if restoring fails.

[Osier Yang]

于 2011年04月06日 22:25, Eric Blake 写道:
> On 04/06/2011 07:11 AM, Daniel Berteaud wrote:
>>>    The problem there is that you are changing the command behaviour.
>>> The user may snapshot the disk separately and use this to implement
>>> a simplified domain snapshot. Doing the remove may avoid troubles
>>> for those not knowing what they are doing, but also break something
>>> for those who know what they are doing.
>>
>> I completely agree, virsh restore shouldn't remove the saved state. I
>> often use this and restore several time the same dump, because I
>> independently save (and restore) the VM disk.
>
> Hmm, I should read the full thread before replying.  Altering a saved
> image to mark it as successfully restored would potentially interfere
> with this usage pattern (you'd either have to pass --force to the
> restore to override the bit, or we'd have to introduce a new command
> that can be used to easily remove the bit to be called in tandem with
> rewinding disk state back to its earlier point).
>
> I guess what that means for today is that this patch series should focus
> just on managedsave behavior, and for save/restore should focus only on
> documentation.
>

Oh, okay, I should read the full thread too. :)

>
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list