[libvirt] [PATCH] Standard on error variable name in libvirtd dispatcher
Daniel P. Berrange
berrange at redhat.com
Wed Apr 13 15:07:11 UTC 2011
On Wed, Apr 13, 2011 at 09:03:20AM -0600, Eric Blake wrote:
> On 04/13/2011 08:57 AM, Daniel P. Berrange wrote:
> > Some dispatcher methods have a parameter
> >
> > remote_error *err,
> >
> > Instead of the more normal
> >
> > remote_error *rerr,
> >
> > * daemon/remote.c: s/err/rerr/
> > ---
> > daemon/remote.c | 108 +++++++++++++++++++++++++++---------------------------
> > 1 files changed, 54 insertions(+), 54 deletions(-)
>
> Cosmetic and mechanical. I'm guessing that doing this will help
> automate your future conversions to the improved generic RPC
> implementation :)
The idea is that it'll make it easier to review the libvirtd
part of the RPC impl, because all these no-op changes will be
separate from the actual conversion.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list