[libvirt] [PATCH] Remove C99 variable declare in PHYP network driver

Daniel P. Berrange berrange at redhat.com
Wed Apr 13 18:15:51 UTC 2011


Move the virInterfacePtr declaration to the top of the
function to avoid jump uninitialized variable warnings

* src/phyp/phyp_driver.c: Fix var declaration
---
 src/phyp/phyp_driver.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Pushed to fix the broken build...

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index b5145db..a1b6819 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -3587,6 +3587,7 @@ phypInterfaceLookupByName(virConnectPtr conn, const char *name)
     int slot = 0;
     int lpar_id = 0;
     char mac[PHYP_MAC_SIZE];
+    virInterfacePtr result = NULL;
 
     /*Getting the slot number for the interface */
     virBufferAddLit(&buf, "lshwres ");
@@ -3667,7 +3668,7 @@ phypInterfaceLookupByName(virConnectPtr conn, const char *name)
 
     memcpy(mac, ret, PHYP_MAC_SIZE-1);
 
-    virInterfacePtr result = virGetInterface(conn, name, ret);
+    result = virGetInterface(conn, name, ret);
 
     VIR_FREE(cmd);
     VIR_FREE(ret);
-- 
1.7.4.2




More information about the libvir-list mailing list