[libvirt] [PATCH] migrate VMs between different-endian hosts

[Stefan Berger]

On 04/14/2011 02:20 PM, Eric Blake wrote:
> On 04/14/2011 11:50 AM, Stefan Berger wrote:
>>>> +++ libvirt-acl/src/qemu/qemu_driver.c
>>>> @@ -43,6 +43,7 @@
>>>>    #include<sys/wait.h>
>>>>    #include<sys/ioctl.h>
>>>>    #include<sys/un.h>
>>>> +#include<byteswap.h>
>>> This won't work unless you also modify bootstrap.conf to include the
>>> gnulib byteswap module.
>>>
>>> ACK with that nit fixed.
>>>
>> I don't think it's necessary to include it there:
>>
>> # rpm -q --whatprovides /usr/include/byteswap.h
>> glibc-headers-2.12.90-21.x86_64
> Not all the world is glibc.  BSD and mingw lack byteswap.h, and qemu
> compiles on more than just Linux.  While I'm not sure if any non-Linux
> hosts default to compiling the qemu driver at the current moment, that
> does not mean that we should not be thinking about the portability
> aspects.  Adding a one-liner inclusion of the byteswap module to
> bootstrap.conf will avoid any questions of portability pitfalls.
>
Push with that nit fixed.

   Stefan