[libvirt] [PATCH] nwfilter: Fix memory leak in the ebtables subdriver

Eric Blake eblake at redhat.com
Sat Apr 30 13:42:03 UTC 2011


On 04/30/2011 05:12 AM, Matthias Bolte wrote:
> Call shutdown functions for all subcompontents in nwfilterDriverShutdown.

s/subcompontents/subcomponents/ (twice)

> +++ b/src/conf/nwfilter_conf.c
> @@ -125,6 +125,7 @@ struct int_map {
>   * only one filter update allowed
>   */
>  static virMutex updateMutex;
> +static bool initialized = false;

You could omit '= false' and still get the same results, since static
storage is guaranteed to be zero-initialized, but that's just style and
does not have to be changed.

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110430/61c62856/attachment-0001.sig>


More information about the libvir-list mailing list