[libvirt] [PATCH] network: eliminate lag in updating dnsmasq hosts files

Eric Blake eblake at redhat.com
Thu Aug 4 14:04:05 UTC 2011


On 08/03/2011 02:17 PM, Laine Stump wrote:
> This addresses https://bugzilla.redhat.com/show_bug.cgi?id=713728
>
> When "defining" a new network (or one that exists but isn't currently
> active) the new definition is stored in network->def, but for a
> network that already exists and is active, the new definition is
> stored in network->newDef, and then moved over to network->def as soon
> as the network is destroyed.
>
> However, the code that writes the dhcp and dns hosts files used by
> dnsmasq was always using network->def for its information, even when
> the new data was actually in network->newDef, so the hosts files
> always lagged one edit behind the definition.
>
> This patch changes the code to keep the pointer to the new definition
> after it's been assigned into the network, and use it directly
> (regardless of whether it's stored in network->newDef or network->def)
> to construct the hosts files.
> ---
>   src/network/bridge_driver.c |   22 +++++++++++-----------
>   1 files changed, 11 insertions(+), 11 deletions(-)
>

ACK

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list