[libvirt] [PATCH] storage: avoid missing break in default branch of switch statement

[Eric Blake]

On 08/08/2011 04:20 AM, Alex Jia wrote:
> Detected by Coverity.
>
> * src/storage/storage_backend.c: avoid missing break in default branch.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=721335
>
> Signed-off-by: Alex Jia<ajia at redhat.com>
> ---
>   src/storage/storage_backend.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
> index 6243d1e..004bc66 100644
> --- a/src/storage/storage_backend.c
> +++ b/src/storage/storage_backend.c
> @@ -819,6 +819,7 @@ virStorageBackendCreateQemuImg(virConnectPtr conn,
>               virCommandAddArgFormat(cmd, "%lluK", size_arg);
>               if (do_encryption)
>                   virCommandAddArg(cmd, "-e");
> +            break;
>           }

NACK.  The last label in a switch statement does not need a break, so 
this can't possibly fix a bug.  Can you post the actual Coverity trace 
that led you to believe this was where it was reporting about?  I 
suspect that this is instead a duplicate of 
https://bugzilla.redhat.com/show_bug.cgi?id=711151.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org