[libvirt] [PATCH] nwfilter: tolerate disappearing interfaces while instantiating filter

Eric Blake eblake at redhat.com
Wed Aug 10 15:14:59 UTC 2011


On 08/10/2011 04:34 AM, Stefan Berger wrote:
> When instantiating a filter, a VM may disappear and remove its tap
> interfaces. Tolerate this case and don't report an error.
>
> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
>

ACK with one nit:

> + rc = 0;
> + goto exit;
> + }
> +
> rc = __virNWFilterInstantiateFilter(conn,
> teardownOld,
> net->ifname,
> @@ -917,6 +924,7 @@ _virNWFilterInstantiateFilter(virConnect
> false,
> foundNewFilter);
>
> +exit:

Coding conventions document that we prefer 'cleanup:' rather than 
'exit:' for the goto statement and label name.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list