[libvirt] [PATCH 1/3] Swap virDomain / virFomainSnapshot declaration

Eric Blake eblake at redhat.com
Fri Aug 12 22:19:55 UTC 2011


On 04/12/2011 12:06 AM, Philipp Hahn wrote:

0.33 years(!) later:

> In preparation for storing the domain description with the snapshot,
> swap the order of declaration.
>
> Signed-off-by: Philipp Hahn<hahn at univention.de>
> ---
>   src/conf/domain_conf.h |  100 ++++++++++++++++++++++++------------------------
>   1 files changed, 50 insertions(+), 50 deletions(-)

Shouldn't strictly be necessary - can't a forward declaration do the 
job?  But I do like the concept - a snapshot contains a domain, so 
domain is the smaller struct and should be listed first.

It wasn't too hard to rebase this one, so ACK and pushed.

I've already found a couple of mails from you in the backlog of my inbox 
today with valid bug reports or patches.

To all list readers:
Feel free to ping the list on issues after a week or so if you think 
people are dragging their feet on giving a reply (even if the reply is a 
nack or a wait, that's better than silence).

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list