[libvirt] [PATCH] qemu: error message should show uri instead of (null)

[Eric Blake]

On 08/15/2011 07:43 AM, Daniel Veillard wrote:
>>           qemuReportError(VIR_ERR_OPERATION_FAILED,
>> -                        _("Failed to connect to remote libvirt URI %s"), uri);
>> +                        _("Failed to connect to remote libvirt URI %s"), dconnuri);
>>           return -1;
>>       }
>>
>
>    Seems to me that if dconnuri was NULL we would certainly hit dconn == NULL
> as a result. That said we were printing the wrong URL so that's still an
> improvement :-)
>
>      maybe use (dconnuri ? dconnuri : "NULL")

We already have a macro for that: NULLSTR(dconnuri).

> or test and make 2 spearate messages, but that probably excessive :-)

Agree that 2 messages is overkill in this case.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org