[libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

[Osier Yang]

于 2011年08月16日 17:24, Alex Jia 写道:
> * src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence
>    clang warning.
>
> Detected by ccc-analyzer:
>
>    CC     libvirt_driver_qemu_la-qemu_migration.lo
> qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read
>      ret = qemuMigrationConfirm(driver, sconn, vm,
>      ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> ---
>   src/qemu/qemu_migration.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 5510493..469bb4a 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -2050,6 +2050,9 @@ finish:
>        * do, but fortunately worst case is that there is a
>        * domain left in 'paused' state on source.
>        */
> +    if (ret<  0)
> +        VIR_WARN("Guest %s probably left in 'paused' state on source",
> +                 vm->def->name);

Error is already reported by qemuMigrationConfirm if it fails
on resuming the guest on source host. Think it's not worth
to introduce a warning just to avoid the clang warning.

>
>    cleanup:
>       if (ddomain) {