[libvirt] [PATCH 5/8] test: Allow to undefine a running domain

[Eric Blake]

On 08/19/2011 08:12 AM, Eric Blake wrote:
>> - virDomainRemoveInactive(&privconn->domains,
>> - privdom);
>> - privdom = NULL;
>> + if (virDomainObjIsActive(vm)) {
>> + vm->persistent = 0;
>
> Spoke too soon. This doesn't compile. I'll be pushing this.
>
> diff --git i/src/test/test_driver.c w/src/test/test_driver.c
> index 422486e..ec2bd75 100644
> --- i/src/test/test_driver.c
> +++ w/src/test/test_driver.c
> @@ -2604,8 +2604,8 @@ static int testDomainUndefineFlags(virDomainPtr
> domain,
> event = virDomainEventNewFromObj(privdom,
> VIR_DOMAIN_EVENT_UNDEFINED,
> VIR_DOMAIN_EVENT_UNDEFINED_REMOVED);
> - if (virDomainObjIsActive(vm)) {
> - vm->persistent = 0;
> + if (virDomainObjIsActive(privdom)) {
> + privdom->persistent = 0;

And even with that fixed, it now introduces a 'make check' failure, due 
to tests/undefine being hard-wired to the old semantics.

I'll be fixing that test, and pushing something soon under the 
build-breaker rule.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org