[libvirt] [PATCH] daemon: Move TLS initialization to virInitialize

[Eric Blake]

On 08/24/2011 08:19 AM, Michal Privoznik wrote:
> My previous patch 74c75671331d284e1f777f9692b72e9737520bf0
> introduced a regression by removing TLS initialization from client.
> ---
>   daemon/libvirtd.c |    1 -
>   src/libvirt.c     |    3 +++
>   2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index 5969a82..8f04a99 100644
> --- a/daemon/libvirtd.c
> +++ b/daemon/libvirtd.c
> @@ -1516,7 +1516,6 @@ int main(int argc, char **argv) {
>       virHookCall(VIR_HOOK_DRIVER_DAEMON, "-", VIR_HOOK_DAEMON_OP_START,
>                   0, "start", NULL);
>
> -    virNetTLSInit();

This looks odd - having the tls init in a 3rd party call via 
virInitialize, but the tls de-init is still directly in libvirtd.

Either we need a virDeinitialize which does the virNetTLSDeinit, and 
libvirtd calls virDeinitialize; or you can just drop all calls to 
virNetTLSDeinit.

ACK that this fixes the bug, but I think we could do with a v2 that 
avoids the asymmetry introduced by this v1 patch.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org