[libvirt] [PATCH] util: only fchown newly created files in virFileOpenAs

[Eric Blake]

On 08/24/2011 03:01 AM, Laine Stump wrote:
> virFileOpenAs takes desired uid:gid as arguments, and not only uses
> them for a fork/setuid/setgid when retrying failed open operations,
> but additionally always forces the opened file to be owned by the
> given uid:gid.
>
> One example of the problems this causes is that, when restoring a
> domain from a file that is owned by the qemu user, opening the file
> chowns it to root. if dynamic_ownership=1 this is coincidentally
> expected, but if dynamic_ownership=0, no existing file should ever
> have its ownership changed.
>
> This patch adds an extra check before calling fchown() - it only does
> it if O_CREAT was passed to virFileOpenAs() in the openflags.
> ---
>   src/util/util.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org