[libvirt] [PATCH 11/3] qemu: plug child process leak on domain core dump
Laine Stump
laine at laine.org
Tue Aug 2 20:59:19 UTC 2011
On 08/02/2011 04:38 PM, Eric Blake wrote:
> Detected by Coverity. Leak introduced by typo in commit 58e668d2.
>
> * src/qemu/qemu_driver.c (doCoreDump): Use correct function.
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 0297159..ea24df8 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -2717,7 +2717,7 @@ doCoreDump(struct qemud_driver *driver,
>
> cleanup:
> VIR_FORCE_CLOSE(fd);
> - virFileDirectFdClose(directFd);
> + virFileDirectFdFree(directFd);
> if (ret != 0)
> unlink(path);
> return ret;
ACK.
More information about the libvir-list
mailing list