[libvirt] [PATCH 0/8] Cleanup improper VIR_ERR_NO_SUPPORT use

Osier Yang jyang at redhat.com
Tue Aug 23 13:52:53 UTC 2011


于 2011年08月23日 21:52, Eric Blake 写道:
> On 08/23/2011 07:45 AM, Osier Yang wrote:
>> 于 2011年08月23日 17:39, Osier Yang 写道:
>>> Error code VIR_ERR_NO_SUPPORT will be translated to "this function
>>> is not supported by the connection driver", however, it's used
>>> across the whole projects, this patch is trying to cleanup all
>>> the improper use in the source tree.
>>>
>>> The modification can be grouped to 3 following groups:
>>>
>>> 1) The error intends to tell user it's invalid operation.
>>>
>>> s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID.
>>>
>>> 2) The error intends to tell the configuration of domain
>>> is not supported.
>>>
>>> s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/
>>>
>>> 3) The error intends to tell the function is not implemented
>>> on some platform.
>>>
>>> * s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID/
>>> * and add error strings
>
> ACK series - all relatively simple cleanups, and all make sense.
>
>> Argh, pushed these series carelessly. Will revert it if there is
>> something wrong.
>
> No fears - nothing to revert. :)
>
Thanks, :-)

Osier




More information about the libvir-list mailing list