[libvirt] [PATCH 43/26] snapshot: use SELinux and lock manager with external snapshots

Eric Blake eblake at redhat.com
Wed Aug 24 14:34:09 UTC 2011


On 08/23/2011 05:25 PM, Eric Blake wrote:
> With this, it is now possible to create external snapshots even
> when SELinux is enforcing, and to protect the new file with a
> lock manager.
>
> * src/qemu/qemu_driver.c
> (qemuDomainSnapshotCreateSingleDiskActive): Create and register
> new file with proper permissions and locks.
> (qemuDomainSnapshotCreateDiskActive): Update caller.
> ---
>
> I ran out of time to thoroughly test this today, but wanted to at least
> get it posted.  Once I test it, I'll post the v3 of my series.

Good thing I tested - I was suffering from a double-free (v3 will be fixed).


> +    }
> +
> +    disk->src = origsrc;
> +    origsrc = NULL;
> +    disk->driverType = driverType;

This was supposed to be origdriver, not driverType.

> +    origdriver = NULL;

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list