[libvirt] [PATCH v2] remote: Refuse connecting to remote socket

[Eric Blake]

On 08/24/2011 03:41 AM, Michal Privoznik wrote:
> If users wants to connect to remote unix socket, e.g.
> 'qemu+unix://<remote>/system' currently the<remote>  part is ignored,
> ending up connecting to localhost. Connecting to remote socket is not
> supported and user should have used TLS/TCP/SSH instead.
> ---
>   src/remote/remote_driver.c |   13 ++++++++++---
>   1 files changed, 10 insertions(+), 3 deletions(-)

> +                else if (STRCASEEQ (transport_str, "unix")) {
> +                    if (conn->uri->server) {
> +                        remoteError(VIR_ERR_INVALID_ARG, "%s",
> +                                    _("rempte_open: using unix socket and "
 > +                                      "remote server is not 
supported."));

s/rempte_open/remote_open/

Then again, remoteError already automatically adds the function name 
(since it is a macro that includes __func__), so your repeat of the name 
is redundant.

Also, why not list the parsed server, in case it helps the user:

remoteError(VIR_ERR_INVALID_ARG,
             _("using unix socket and remote server '%s' is not supported"),
             conn->uri->server

ACK with that fixed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org