[libvirt] [PATCH] Fix command test wrt gnutls initialize & fix debugging

[Eric Blake]

On 08/25/2011 05:08 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> The VIR_TEST_DEBUG and VIR_TEST_VERBOSE env vars did not work
> because we replaced 'environ' with 'newenv'. Simply calling
> virTestGetDebug/Verbose() before replacing the 'environ' ensures
> we have processed the env variables.
>
> The gnutls initialization code opens /dev/urandom and keeps that
> FD around for later use. We have code which kills off FDs 3-5
> to avoid interfereing with our test case. Move the virInitialize
> call before this point, so it kills off the gnutls /dev/urandom
> FD which is irrelevant for testing purposes
>
> * tests/commandtest.c: Fix test debugging&  make it robust against
>    opened FDs
> ---
>   tests/commandtest.c |    9 +++++++--
>   1 files changed, 7 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org