[libvirt] [PATCHv2 4/5] hyperv: Add basic driver for Microsoft Hyper-V

[Matthias Bolte]

2011/8/20 Eric Blake <eblake at redhat.com>:
> On 08/03/2011 09:00 AM, Matthias Bolte wrote:
>>
>> Domain listing, basic information retrieval and domain life cycle
>> management is implemented. But currently the domian XML output
>
> s/domian/domain/
>
>> lacks the complete devices section.
>>
>> The driver uses OpenWSMAN to directly communicate with an Hyper-V
>
> s/an Hyper/a Hyper/
>
> Since the H in Hyper is aspirated, we use 'a' instead of 'an'.  Blame
> English for being stupid.
>
>> server over its WS-Management interface exposed via Microsoft WinRM.
>>
>> The driver is based on the work of Michael Sievers. This started in
>> the same master program project group at the University of Paderborn
>> as the ESX driver.
>>
>> See Michael's blog for details: http://hyperv4libvirt.wordpress.com/
>> ---

>> +    /* Strip the string to fit more relevant information in 32 chars */
>> +    tmp = processorList->data->Name;
>> +
>> +    while (*tmp != '\0') {
>> +        if (STRPREFIX(tmp, "  ")) {
>> +            memmove(tmp, tmp + 1, strlen(tmp + 1) + 1);
>> +            continue;
>> +        } else if (STRPREFIX(tmp, "(R)") || STRPREFIX(tmp, "(C)")) {
>> +            memmove(tmp, tmp + 3, strlen(tmp + 3) + 1);
>> +            continue;
>> +        } else if (STRPREFIX(tmp, "(TM)")) {
>
> Cute.  Hopefully no one complains about stripping copyright and trademark
> notations in our compressed strings.  I think you're okay, but IANAL.

This is the same logic as in the ESX driver.

> Conditional ACK - I pointed out a couple more flag-variant functions that
> are trivially implemented.  I'm okay if you post a delta patch for review,
> then squash it in before pushing, since that would be shorter than a
> full-blown v3.

Here's an interdiff for v3.

-- 
Matthias Bolte
http://photron.blogspot.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004_interdiff.patch
Type: text/x-diff
Size: 3492 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110826/aff22f2f/attachment-0001.bin>