[libvirt] [PATCH] virsh: Fix possible deadlock when virsh is about to exit

Daniel Veillard veillard at redhat.com
Thu Dec 1 03:52:10 UTC 2011


On Wed, Nov 30, 2011 at 02:59:56PM -0700, Eric Blake wrote:
> On 11/30/2011 12:42 PM, Jiri Denemark wrote:
> > Not only was ctl->quit accessed without a mutex but unfortunately,
> > virEventAddTimeout only interrupts the poll when event loop is running
> > so the hack needs to add a timeout that will make next poll return
> > immediately without blocking.
> > ---
> >  tools/virsh.c |   39 +++++++++++++++++++++++++++++++++------
> >  1 files changed, 33 insertions(+), 6 deletions(-)
> 
> ACK.

  ACK too, and pushed !

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/




More information about the libvir-list mailing list