[libvirt] [PATCH libvirt-glib 12/15] Use test -d FOO && test -d BAR instead of test -d FOO -a -d BAR

Christophe Fergeau cfergeau at redhat.com
Thu Dec 1 15:16:12 UTC 2011


ACK

On Thu, Dec 01, 2011 at 02:05:40PM +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> For greater portability do not rely on the test binary having
> a -a option
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4092bef..805cd9b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -138,8 +138,8 @@ if test "$with_python" != "no" ; then
>      fi
>      if test "$PYTHON_VERSION" != ""
>      then
> -	if test -r $with_python/include/python$PYTHON_VERSION/Python.h -a \
> -	   -d $with_python/lib/python$PYTHON_VERSION/site-packages
> +	if test -r $with_python/include/python$PYTHON_VERSION/Python.h && \
> +	   test -d $with_python/lib/python$PYTHON_VERSION/site-packages
>  	then
>  	    PYTHON_INCLUDES=$with_python/include/python$PYTHON_VERSION
>  	    PYTHON_SITE_PACKAGES=$libdir/python$PYTHON_VERSION/site-packages
> -- 
> 1.7.6.4
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111201/b87d849c/attachment-0001.sig>


More information about the libvir-list mailing list