[libvirt] [RFC v4 PATCH 4/5] PowerPC : Clean up qemuBuildCommandLine to remove x86-specific assumptions from generic code.

[Stefan Berger]

On 12/01/2011 01:06 PM, Prerna Saxena wrote:
> From: Prerna Saxena<prerna at linux.vnet.ibm.com>
> Date: Mon, 21 Nov 2011 18:20:42 +0530
> Subject: [PATCH 4/5] Clean up qemuBuildCommandLine to remove x86-
> specific assumptions from generic code.
>
> This implements the minimal set of changes needed in libvirt to launch a
> PowerPC-KVM based guest.
> It removes x86-specific assumptions about choice of serial driver backend
> from generic qemu guest commandline generation code.
> It also restricts the ACPI capability to be available for an x86 or
> x86_64 domain.
> This is not a complete solution -- it still does not guarantee libvirt
> the capability to flag non-supported options in guest XML. (Eg, an ACPI
> specification in a PowerPC guest XML will still get processed, even
> though qemu-system-ppc64 does not support it while qemu-system-x86_64 does.)
> This drawback exists because libvirt falls back on qemu to query supported
> features, and qemu '-h' blindly lists all capabilities -- irrespective
> of whether they are available while emulating a given architecture or not.
> The long-term solution would be for qemu to list out capabilities based
> on architecture and platform -- so that libvirt can cleanly make out what
> devices are supported on an arch (say 'ppc64') and platform (say, 'mac99').
>
> Signed-off-by: Prerna Saxena<prerna at linux.vnet.ibm.com>
> diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
> index b680295..3978b2b 100644
> --- a/src/qemu/qemu_command.h
> +++ b/src/qemu/qemu_command.h
> @@ -53,6 +53,12 @@ virCommandPtr qemuBuildCommandLine(virConnectPtr conn,
>                                      enum virNetDevVPortProfileOp vmop)
>       ATTRIBUTE_NONNULL(1);
>
> +/* Generate string for arch-specific '-device' parameter */
> +char *
> +qemuBuildChrDeviceStr (virDomainChrDefPtr serial,
> +                       char *os_arch,
> +                       char *machine);
> +

The nit here would be to remove that space.

>   /* With vlan == -1, use netdev syntax, else old hostnet */
>   char * qemuBuildHostNetStr(virDomainNetDefPtr net,
>                              char type_sep,

ACK