[libvirt] [PATCH 1/2] command: handle empty buffer argument correctly
Eric Blake
eblake at redhat.com
Sat Dec 3 23:00:19 UTC 2011
On 12/03/2011 02:18 PM, Stefan Berger wrote:
> On 12/02/2011 01:50 PM, Eric Blake wrote:
>> virBufferContentAndReset (intentionally) returns NULL for a buffer
>> with no content, but it is feasible to invoke a command with an
>> explicit empty string.
>>
>> * src/util/command.c (virCommandAddEnvBuffer): Reject empty string.
>> (virCommandAddArgBuffer): Allow explicit empty argument.
>> * tests/commandtest.c (test9): Test it.
>> * tests/commanddata/test9.log: Adjust.
>> ---
>> src/util/command.c | 13 ++++++++++++-
>> tests/commanddata/test9.log | 4 +++-
>> tests/commandtest.c | 13 ++++++++++++-
>> 3 files changed, 27 insertions(+), 3 deletions(-)
>
> ACK
Thanks; pushed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111203/720342f1/attachment-0001.sig>
More information about the libvir-list
mailing list