[libvirt] [PATCH] storage: Activate/deactivate logical volumes only on local node
jyang at redhat.com
Mon Dec 12 13:53:11 UTC 2011
On 2011年12月12日 17:54, Michal Privoznik wrote:
> On 12.12.2011 08:40, Osier Yang wrote:
>> From: Rommer<rommer at active.by>
>> Current "-ay | -an" has problems on pool starting/refreshing if
>> the volumes are clustered. Rommer has posted a patch to list 2
>> months ago.
>> But IMO we shouldn't skip the inactived vols. So this is a squashed
>> patch by Rommer.
>> Signed-off-by: Rommer<rommer at active.by>
>> src/storage/storage_backend_logical.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
>> index 1420ede..6a235f6 100644
>> --- a/src/storage/storage_backend_logical.c
>> +++ b/src/storage/storage_backend_logical.c
>> @@ -51,7 +51,7 @@ virStorageBackendLogicalSetActive(virStoragePoolObjPtr pool,
>> const char *cmdargv;
>> cmdargv = VGCHANGE;
>> - cmdargv = on ? "-ay" : "-an";
>> + cmdargv = on ? "-aly" : "-aln";
>> cmdargv = pool->def->source.name;
>> cmdargv = NULL;
> Is it just me or vgchange has strange arguments parsing logic?
It's of vgchange. :-)
> I'd expect -aly to be the same as -a -l -y as in all other utilities
> within unix world. Anyway, that's not show stopper.
More information about the libvir-list