[libvirt] [PATCH] nwfilter: Do not require DHCP requests to be broadcast
Eric Blake
eblake at redhat.com
Wed Dec 21 15:29:29 UTC 2011
On 12/21/2011 08:19 AM, Stefan Berger wrote:
> Remove the requirement that DHCP messages have to be broadcasted.
It might be worth listing more rationale, such as a scenario that fails
without this patch.
>
> ---
> src/nwfilter/nwfilter_ebiptables_driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c
> ===================================================================
> --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c
> +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c
> @@ -3245,9 +3245,8 @@ ebtablesApplyDHCPOnlyRules(const char *i
>
> virBufferAsprintf(&buf,
> CMD_DEF("$EBT -t nat -A %s"
> - " -s %s -d Broadcast "
> + " -s %s"
> " -p ipv4 --ip-protocol udp"
> - " --ip-src 0.0.0.0 --ip-dst 255.255.255.255"
But assuming that it helped a real-life scenario, ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111221/107210f9/attachment-0001.sig>
More information about the libvir-list
mailing list