[libvirt] [PATCH v2] Add new attribute writeout to <filesystem> element

Deepak C Shetty deepakcs at linux.vnet.ibm.com
Thu Dec 22 17:45:29 UTC 2011


On 12/22/2011 10:52 PM, Deepak C Shetty wrote:
> On 12/22/2011 07:50 PM, Eric Blake wrote:
>> On 12/22/2011 03:10 AM, Deepak C Shetty wrote:
>>
>> I still don't like the proposed XML.  We need to get consensus on where
>> to put it, with my proposal being:
>>
>> <filesystem type='mount'>
>> <driver type='path' write='immediate'/>
>> <source dir='/export/to/guest'/>
>> <target dir='mount_tag'/>
>> </filesystem>
>>
>
> Currrently, the way its implemented in qemu's hw/9pfs is that the 
> writeout is not driver specific.
> Its a global flag at the v9fs level i.e. V9FS_IMMEDIATE_WRITEOUT. 9pfs 
> maps to 'mount'
> filesystem type in libvirt, hence i put it as part of the filesystem 
> attribute.
>
Hi Eric,
    I saw your response to my v1 patch (should have seen before) and i 
think I am convinced that
  it makes more sense to have this as part of the <driver ... element. 
Regarding the attribute name,
will it be more appropriate to have writeback='immediate' ? Once we have 
consensus, i will post
v3 patch. Thanks - Deepak




More information about the libvir-list mailing list