[libvirt] [PATCH] virsh: correct the cmdDomIfGetLink function return value error

Peter Krempa pkrempa at redhat.com
Thu Dec 8 09:25:19 UTC 2011


On 12/08/2011 07:30 AM, ajia at redhat.com wrote:
> From: Alex Jia<ajia at redhat.com>
>
> * tools/virsh.c: Although finding interface with matching mac addr, forgot to
> set 'ret' boolean value to 'true'.
>
> * how to reproduce?
>    % virsh domif-getlink<guest name>  <interface mac>
>    % echo $?
>
> Signed-off-by: Alex Jia<ajia at redhat.com>
> ---

Your patch failed to apply as the context is ambigous with a function 
not far away from this. Also 3-way merge failed due to invalid git 
hashes. You probably had more patches on a branch which are not upstream.

Anyways, thanks for finding this. I'm going to push a fix based on your 
patch.



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-virsh-return-correct-value-from-cmdDomIfGetLink.patch
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111208/b16ff0a9/attachment-0001.ksh>


More information about the libvir-list mailing list