[libvirt] [PATCH 1/8] Convert Xen & VBox drivers to use virDomainEventState
Eric Blake
eblake at redhat.com
Wed Dec 14 18:26:57 UTC 2011
On 12/14/2011 11:17 AM, Eric Blake wrote:
> On 12/13/2011 05:38 PM, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange at redhat.com>
>>
>> The Xen & VBox drivers deal with callbacks & dispatching of
>> events directly. All the other drivers use a timer to dispatch
>> events from a clean stack state, rather than deep inside the
>> drivers. Convert Xen & VBox over to virDomainEventState so
>> that they match behaviour of other drivers
>>
>> * src/conf/domain_event.c: Return count of remaining
>> callbacks when unregistering event callback
>
> Does this part of the commit message belong with 2/8?
>
>> * src/vbox/vbox_tmpl.c, src/xen/xen_driver.c,
>> src/xen/xen_driver.h: Convert to virDomainEventState
>> ---
>> src/conf/domain_event.c | 58 ++++++++++++++++--
>> src/conf/domain_event.h | 6 +-
>
> The rename of virDomainEventStateDeregisterAny to
> virDomainEventStateDeregisterID wasn't mentioned in the commit message.
> Did you rebase things incorrectly? That said, these changes look
> useful, even if they were meant for a separate commit.
Actually, compiling this patch fails:
test/test_driver.c: In function 'testDomainEventDeregisterAny':
test/test_driver.c:5462:5: error: implicit declaration of function
'virDomainEventStateDeregisterAny' [-Werror=implicit-function-declaration]
>
>> src/vbox/vbox_tmpl.c | 146 +++++++++++++++++++++++++----------------------
>> src/xen/xen_driver.c | 68 ++++++++++------------
>> src/xen/xen_driver.h | 4 +-
>> 5 files changed, 164 insertions(+), 118 deletions(-)
>
> ACK.
Can you resubmit with that fixed?
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111214/aae889a4/attachment-0001.sig>
More information about the libvir-list
mailing list