[libvirt] [PATCH] python: plug memory leak on libvirt_virConnectOpenAuth

Eric Blake eblake at redhat.com
Mon Dec 19 18:53:16 UTC 2011


On 12/19/2011 02:47 AM, Osier Yang wrote:
> On 2011年12月19日 16:12, ajia at redhat.com wrote:
>> From: Alex Jia<ajia at redhat.com>
>>
>> * Detected by valgrind. Leak introduced in commit 5ab109f.

Wow - present since 0.4.1!

>> +++ b/python/libvirt-override.c
>> @@ -1520,6 +1520,7 @@ libvirt_virConnectOpenAuth(PyObject *self
>> ATTRIBUTE_UNUSED, PyObject *args) {
>>
>>       c_retval = virConnectOpenAuth(name,&auth, flags);
>>       LIBVIRT_END_ALLOW_THREADS;
>> +    free(auth.credtype);
>>       py_retval = libvirt_virConnectPtrWrap((virConnectPtr) c_retval);
>>       return(py_retval);
>>   }
> 
> ACK

Pushed.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111219/2c878d55/attachment-0001.sig>


More information about the libvir-list mailing list